From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934Ab1GYQKI (ORCPT ); Mon, 25 Jul 2011 12:10:08 -0400 Received: from oproxy4-pub.bluehost.com ([69.89.21.11]:36571 "HELO oproxy4-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751382Ab1GYQKG (ORCPT ); Mon, 25 Jul 2011 12:10:06 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=xenotime.net; h=Received:Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:Organization:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=Kxfs1r/CTclUE7RNVNFDvJiH5t/yiVXZBIwbwqSeSS9xG4WiMfT2dROkSV+bU+8dIAaWnaP7f6RqCpOU3jXwF2CTg+xOVVeINDjIA3ou2wjrKWxHDc/NZ4NDi9275d43; Date: Mon, 25 Jul 2011 09:10:03 -0700 From: Randy Dunlap To: Takashi Iwai Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: Build regressions/improvements in v3.0-rc7 (sound/isa/) Message-Id: <20110725091003.c3453b8b.rdunlap@xenotime.net> In-Reply-To: References: <1310585610-434-1-git-send-email-geert@linux-m68k.org> <20110724122624.324d10dc.rdunlap@xenotime.net> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2011 09:37:53 +0200 Takashi Iwai wrote: > At Sun, 24 Jul 2011 12:26:24 -0700, > Randy Dunlap wrote: > > > > On Wed, 13 Jul 2011 21:33:30 +0200 Geert Uytterhoeven wrote: > > > > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_disable': => 544 > > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 302 > > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_program': => 244 > > > + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 509 > > > + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_program': => 417 > > > + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_disable': => 177 > > > + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_program': => 79 > > > + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_pointer': => 619 > > > + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_program': => 591 > > > + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_pointer': => 456 > > > + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_program': => 276 > > > + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_pointer': => 425 > > > + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_program': => 172 > > > + src/sound/isa/sscape.c: error: implicit declaration of function 'snd_dma_program': => 481 > > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_disable': => 1695 > > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 1160 > > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_program': => 1025 > > > > All of these source files do #include , > > but these missing/implicit functions are conditional: > > > > #ifdef CONFIG_ISA_DMA_API > > #define DMA_MODE_NO_ENABLE 0x0100 > > > > void snd_dma_program(unsigned long dma, unsigned long addr, unsigned int size, unsigned short mode); > > void snd_dma_disable(unsigned long dma); > > unsigned int snd_dma_pointer(unsigned long dma, unsigned int size); > > #endif > > > > so should these drivers all depend on ISA_DMA_API ? > > Yes, these are ISA sound cards, so they must have CONFIG_ISA and > CONFIG_ISA_DMA. Although CONFIG_SND_SB8_DSP, CONFIG_SND_SB16_DSP > and CONFIG_SND_WSS_LIB have no direct dependency, but the drivers > selecting these are all in "if SND_ISA" in sound/isa/Kconfig. Hm, yes, they are. > > or should only pieces of each driver depend on ISA_DMA_API ? > > I wonder which configuration makes it possible. > Did you see a similar problem with randconfig? No. This parisc allmodconfig file from linux-next builds has CONFIG_SND_ISA=y but it does not have CONFIG_ISA_DMA_API enabled. Weird. Geert, do you know how this happens? parisc config: http://kisskb.ellerman.id.au/kisskb/buildresult/4323458/config/ from this failed build: http://kisskb.ellerman.id.au/kisskb/buildresult/4323458/ thanks, --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***