mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Joe Perches <joe@perches.com>
Cc: Dave Reisner <d@falconindy.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Dave Reisner <dreisner@archlinux.org>
Subject: Re: [PATCH] printk: add Kconfig for default console loglevel
Date: Tue, 26 Jul 2011 10:16:00 -0700	[thread overview]
Message-ID: <20110726101600.d6a18aa2.rdunlap@xenotime.net> (raw)
In-Reply-To: <1311699705.15386.20.camel@Joe-Laptop>

On Tue, 26 Jul 2011 10:01:45 -0700 Joe Perches wrote:

> On Tue, 2011-07-26 at 09:37 -0700, Randy Dunlap wrote:
> > On Tue, 26 Jul 2011 11:33:51 -0400 Dave Reisner wrote:
> > > Keep the historical default of 7, but allow distributions and users to
> > > tune this value instead of requiring a kernel cmdline parameter.
> > Please explain how this is different from what is already in lib/Kconfig.debug:
> > config DEFAULT_MESSAGE_LOGLEVEL
> > 	int "Default message log level (1-7)"
> > 	range 1 7
> > 	default "4"
> > 	help
> > 	  Default log level for printk statements with no specified priority.
> 
> DEFAULT_MESSAGE_LOGLEVEL sets a KERN_<level> for
> printks without a KERN_<level>.
> 
> > > +config DEFAULT_CONSOLE_LOGLEVEL
> > > +	int "Default console log level (1-7)"
> > > +	range 1 7
> > > +	default "7"
> > > +	help
> > > +	  Default console log level setting for printk statements.
> > > +
> > > +	  This was hard-coded to KERN_INFO (7) since at least 2.6.12. You may
> > > +	  wish to turn this down to 4 for a quieter console.
> > > +
> 
> This allows 'unimportant' messages to not be shown by default.

Thanks.  Maybe Kconfig help text could be clearer.

> I think there are lots of KERN_INFO messages that are
> miscategorized.  This change might cause some shifting
> of KERN_<level>s in the future, so it's OK by me. 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-07-26 17:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 15:33 Dave Reisner
2011-07-26 16:37 ` Randy Dunlap
2011-07-26 17:01   ` Joe Perches
2011-07-26 17:16     ` Randy Dunlap [this message]
2011-07-29 12:58     ` Dave Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110726101600.d6a18aa2.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@linux-foundation.org \
    --cc=d@falconindy.com \
    --cc=dreisner@archlinux.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®