From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602Ab1GZP7j (ORCPT ); Tue, 26 Jul 2011 11:59:39 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:43515 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160Ab1GZP7d (ORCPT ); Tue, 26 Jul 2011 11:59:33 -0400 Date: Tue, 26 Jul 2011 17:59:30 +0200 From: Markus Trippelsdorf To: Linus Torvalds Cc: Steven Liu , Al Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [git pull] vfs pile 1.5 Message-ID: <20110726155930.GB1629@x4.trippels.de> References: <20110725185649.GA22133@ZenIV.linux.org.uk> <20110726033535.GA11939@x4.trippels.de> <20110726082146.GB11939@x4.trippels.de> <20110726085804.GA1639@x4.trippels.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011.07.26 at 08:52 -0700, Linus Torvalds wrote: > On Tue, Jul 26, 2011 at 1:58 AM, Markus Trippelsdorf > wrote: > > > > #ifdefs are ugly. The following fixes the issue for me: > > Actually, I think the proper fix is just the following > (whitespace-damaged). It's better to just set ".get_acl" to NULL, and > it's what we used to do back when it was called "check_acl" (see > commit 4e34e719e45). > Yes, that was my first idea, too. But unfortunately it doesn't work: CC fs/xfs/linux-2.6/xfs_iops.o fs/xfs/linux-2.6/xfs_iops.c: In function ‘xfs_vn_mknod’: fs/xfs/linux-2.6/xfs_iops.c:184:28: error: called object ‘0u’ is not a function make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 -- Markus