From: Oliver Neukum <oneukum@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: better oopsing when frozen
Date: Wed, 27 Jul 2011 12:23:43 +0200 [thread overview]
Message-ID: <201107271223.43874.oneukum@suse.de> (raw)
In-Reply-To: <201107271121.21348.rjw@sisk.pl>
Am Mittwoch, 27. Juli 2011, 11:21:21 schrieb Rafael J. Wysocki:
> > mm... The patch as proposed is very simple, direct, explicit. I
> > suspect that trying to embed this operation within some other one would
> > end up producing a less clear result. Sometimes we do exceptional and
> > weird things, and leaving the code exceptional and weird-looking is
> > better than hiding it in some framework, if you follow what I mean.
>
> My point is that instead of using the oom_killer_disabled variable in
> page_alloc.c, we could use a oom_killer_disabled() function returning
> the value of the new tasks_are_frozen variable. Then,
> oom_killer_disable/enable() won't be necessary any more.
Well, if we do this, it'll be a separate change. Not that I disagree.
Regards
Oliver
--
- - -
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany
- - -
next prev parent reply other threads:[~2011-07-27 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 8:43 Oliver Neukum
2011-07-25 10:10 ` Borislav Petkov
2011-07-26 22:24 ` Rafael J. Wysocki
2011-07-26 22:45 ` Andrew Morton
2011-07-27 9:21 ` Rafael J. Wysocki
2011-07-27 10:23 ` Oliver Neukum [this message]
2011-07-29 19:54 ` [linux-pm] " Pavel Machek
2011-07-29 20:27 ` Oliver Neukum
2011-07-29 20:29 ` Rafael J. Wysocki
2011-07-29 20:27 ` Rafael J. Wysocki
2011-07-29 21:04 ` Oliver Neukum
2011-07-29 21:09 ` Rafael J. Wysocki
2011-07-29 21:17 ` Oliver Neukum
2011-07-29 21:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107271223.43874.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome