mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Mathias Krause <minipli@googlemail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org,
	Maxim Locktyukhin <maxim.locktyukhin@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] crypto, sha1: export sha1_update for reuse
Date: Thu, 28 Jul 2011 22:58:12 +0800	[thread overview]
Message-ID: <20110728145812.GA8396@gondor.apana.org.au> (raw)
In-Reply-To: <1311529994-7924-2-git-send-email-minipli@googlemail.com>

On Sun, Jul 24, 2011 at 07:53:13PM +0200, Mathias Krause wrote:
>
> diff --git a/include/crypto/sha.h b/include/crypto/sha.h
> index 069e85b..7c46d0c 100644
> --- a/include/crypto/sha.h
> +++ b/include/crypto/sha.h
> @@ -82,4 +82,9 @@ struct sha512_state {
>  	u8 buf[SHA512_BLOCK_SIZE];
>  };
>  
> +#if defined(CONFIG_CRYPTO_SHA1) || defined (CONFIG_CRYPTO_SHA1_MODULE)
> +extern int crypto_sha1_update(struct shash_desc *desc, const u8 *data,
> +			      unsigned int len);
> +#endif

Please remove the unnecessary #if.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2011-07-28 14:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24 17:53 [PATCH v2 0/2] crypto, x86: assembler implementation of SHA1 Mathias Krause
2011-07-24 17:53 ` [PATCH v2 1/2] crypto, sha1: export sha1_update for reuse Mathias Krause
2011-07-28 14:58   ` Herbert Xu [this message]
2011-07-28 15:29     ` Mathias Krause
2011-07-30 13:46       ` Herbert Xu
2011-07-31 13:24         ` Mathias Krause
2011-07-24 17:53 ` [PATCH v2 2/2] crypto, x86: SSSE3 based SHA1 implementation for x86-64 Mathias Krause
2011-08-04  6:44   ` Herbert Xu
2011-08-04 17:05     ` Mathias Krause
2011-08-04 17:08       ` Mathias Krause
2011-08-08  5:48       ` Locktyukhin, Maxim
2011-08-14 19:06         ` Mathias Krause
2011-08-11 14:50     ` Andy Lutomirski
2011-08-11 15:08       ` Herbert Xu
2011-08-11 15:15         ` Andrew Lutomirski
2011-08-14 19:09       ` Mathias Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110728145812.GA8396@gondor.apana.org.au \
    --to=herbert@gondor.hengli.com.au \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxim.locktyukhin@intel.com \
    --cc=minipli@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®