From: Greg KH <greg@kroah.com>
To: "Andrew Bird (Sphere Systems)" <ajb@spheresystems.co.uk>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] USB: option driver: add PID for Vodafone-Huawei K3770
Date: Thu, 28 Jul 2011 08:17:20 -0700 [thread overview]
Message-ID: <20110728151720.GA22202@kroah.com> (raw)
In-Reply-To: <201107281210.06455.ajb@spheresystems.co.uk>
On Thu, Jul 28, 2011 at 12:10:05PM +0100, Andrew Bird (Sphere Systems) wrote:
> Hi Sergei,
>
> On Thursday 28 July 2011, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 27-07-2011 20:03, Andrew Bird wrote:
> > > This patch adds the product ID of Huawei's Vodafone K3770 mobile
> > > broadband modem to option.c. This is necessary so that the driver gets
> > > loaded on demand without the intervention of usb_modeswitch. This has
> > > the benefit of it becoming available faster and also ensures that the
> > > option driver is not bound to a network interface that should be claimed
> > > by cdc_ether.
> >
> > You seem to be adding 4 product IDs with the identical patch
> > descriptions. Why not do it in a single patch?
> >
> > > Signed-off-by: Andrew Bird <ajb@spheresystems.co.uk>
> >
> > WBR, Sergei
>
> I'm pretty new to this, but I was following the one patch per change
> idea, so as there are four devices I did a patch for each.
>
> Happy to squash into one if that's more acceptable to people?
As you did it is fine, I'll queue it up next week when I return from
vacation.
greg k-h
prev parent reply other threads:[~2011-07-28 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 16:03 Andrew Bird
2011-07-27 16:03 ` [PATCH 2/4] USB: option driver: add PID for Vodafone-Huawei K3771 Andrew Bird
2011-07-27 16:03 ` [PATCH 3/4] USB: option driver: add PID for Vodafone-Huawei K4510 Andrew Bird
2011-07-27 16:03 ` [PATCH 4/4] USB: option driver: add PID for Vodafone-Huawei K4511 Andrew Bird
2011-07-28 10:58 ` [PATCH 1/4] USB: option driver: add PID for Vodafone-Huawei K3770 Sergei Shtylyov
2011-07-28 11:10 ` Andrew Bird (Sphere Systems)
2011-07-28 15:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728151720.GA22202@kroah.com \
--to=greg@kroah.com \
--cc=ajb@spheresystems.co.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®