From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755967Ab1G1VGd (ORCPT ); Thu, 28 Jul 2011 17:06:33 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:60241 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611Ab1G1VGa (ORCPT ); Thu, 28 Jul 2011 17:06:30 -0400 From: "Rafael J. Wysocki" To: Guennadi Liakhovetski Subject: Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist Date: Thu, 28 Jul 2011 23:07:31 +0200 User-Agent: KMail/1.13.6 (Linux/3.0.0+; KDE/4.6.0; x86_64; ; ) Cc: Linus Torvalds , LKML , linux-sh@vger.kernel.org, "Greg Kroah-Hartman" , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, Chris Ball References: <201107262049.15333.rjw@sisk.pl> <201107272356.16817.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201107282307.31564.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 28, 2011, Guennadi Liakhovetski wrote: > On Wed, 27 Jul 2011, Rafael J. Wysocki wrote: > > > On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote: > > > (added MMC maintainer to CC:) > > > > > > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote: > > > > > > > From: Rafael J. Wysocki > > > > > > > > Fix build issue caused by undefined struct scatterlist in > > > > drivers/mmc/host/tmio_mmc.c. > > > > > > > > Signed-off-by: Rafael J. Wysocki > > > > > > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of > > > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself), > > > > I'm not sure what you mean exactly (perhaps it's too late). > > I mean, that the headers are atm sorted alphabetically and should remain > so, therefore you should add the new header one line higher. Ah. Well, as I said the patch had been merged already, so obviously Linus didn't care. :-) > As for compile failure or not: I haven't seen any compile failures myself, but > the patch is academically correct, because structs, declared in tmio_mmc.h > embed struct scatterlist, therefore the header has to be included in that > header too. Exactly. I've seen a real failure, though. Thanks, Rafael