From: Tejun Heo <tj@kernel.org>
To: Peter Osterlund <peterosterlund2@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: Can you please take a look at bug39852?
Date: Sat, 30 Jul 2011 14:46:44 +0200 [thread overview]
Message-ID: <20110730124644.GM2622@htj.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1107301431580.13015@localhost>
(cc'ing Jens and LKML)
On Sat, Jul 30, 2011 at 02:38:26PM +0200, Peter Osterlund wrote:
> On Sat, 30 Jul 2011, Tejun Heo wrote:
>
> >It looks like spurious lockdep warning via pkt_open(). Seems like the
> >problem has been there since the beginning. What do you think?
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=39852
>
> Yes, it is a spurious warning that has been there since the
> beginning. There were patches to silence the warning back in 2006
>
> https://lkml.org/lkml/2006/7/25/41
>
> but they were considered not the right approach. I don't know what
> the right approach is.
I see. I think the proper solution would be adding a variant of
blkdev_get(), say blkdev_get_nested(), to give the inner open a
different locking class. Jens, what do you think?
Thanks.
--
tejun
parent reply other threads:[~2011-07-30 12:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LFD.2.00.1107301431580.13015@localhost>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110730124644.GM2622@htj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=peterosterlund2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®