From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871Ab1GaQht (ORCPT ); Sun, 31 Jul 2011 12:37:49 -0400 Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:35032 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751421Ab1GaQhn (ORCPT ); Sun, 31 Jul 2011 12:37:43 -0400 Date: Sun, 31 Jul 2011 09:37:40 -0700 From: Randy Dunlap To: David Woodhouse Cc: Arnaud Lacombe , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Roman Zippel Subject: Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' Message-Id: <20110731093740.39f7fbc3.rdunlap@xenotime.net> In-Reply-To: <1312097621.22074.71.camel@i7.infradead.org> References: <1312067499.22074.59.camel@i7.infradead.org> <1312067670.22074.61.camel@i7.infradead.org> <4E34998D.8060806@zytor.com> <4E34A1E4.8040103@zytor.com> <1312097621.22074.71.camel@i7.infradead.org> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Jul 2011 08:33:39 +0100 David Woodhouse wrote: > On Sat, 2011-07-30 at 21:06 -0400, Arnaud Lacombe wrote: > > The principle of least surprise is broken anyway as the proposed patch > > has absolutely no dependency checking and verification. You can `make > > CONFIG_SATA_MV=y allnoconfig', you will _not_ get it set. > > That's always true in kconfig *anyway*. We've *never* really had an > option for "do whatever you need to enable this option". We've even > hard-coded this failure in our language, by introducing this horrible > 'select' thing to work around it. > > I'd no more expect that, than I would for it to write the code for me if > I type 'make CONFIG_BTRFSv2=y oldconfig'. > > So no, it doesn't violate the principle of least surprise. > > > ok, the issue is that you will only be allowed to change visible > > symbols. CONFIG_64BIT is conditionally visible (when ARCH=x86), so > > right now, you can not do on x86-64: > > > > % make ARCH=i386 defconfig > > % make CONFIG_64BIT=n oldconfig # [0] > > That works fine here. What was ARCH set to in your second test? If it's > ARCH=x86_64 then that's expected. That's the whole point of my *other* > patch to make 'ARCH=x86' be the default, so that the value of > CONFIG_64BIT in your .config is *not* forcibly overridden to match the > build host. That's a *separate* bug, which I also have a patch for. Simple question: what does "ARCH=x86" mean? It doesn't mean anything to me without SUBARCH or nnBIT specified. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***