From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203Ab1HANnL (ORCPT ); Mon, 1 Aug 2011 09:43:11 -0400 Received: from cernmx30.cern.ch ([137.138.144.177]:10806 "EHLO CERNMX30.cern.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753095Ab1HANnH (ORCPT ); Mon, 1 Aug 2011 09:43:07 -0400 Date: Mon, 1 Aug 2011 15:40:05 +0200 From: Manohar Vanga To: Martyn Welch CC: , , , Subject: Re: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridge specific Message-ID: <20110801134005.GA9540@becoht-mvanga> Mail-Followup-To: Martyn Welch , gregkh@suse.de, cota@braap.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1312194053-32310-1-git-send-email-manohar.vanga@cern.ch> <1312194053-32310-4-git-send-email-manohar.vanga@cern.ch> <4E36AD01.1050004@ge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4E36AD01.1050004@ge.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [137.138.192.18] Keywords: CERN SpamKiller Note: -50 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I like the approach, I think I agree with Dan, I'd rather see the locking > inside the function for now. Great! I'll put the locking into the function and resend the patch. -- /manohar