From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359Ab1HAQig (ORCPT ); Mon, 1 Aug 2011 12:38:36 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:50409 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752857Ab1HAQia (ORCPT ); Mon, 1 Aug 2011 12:38:30 -0400 Date: Mon, 1 Aug 2011 09:38:24 -0700 From: Dmitry Torokhov To: Grant Likely Cc: Fabien Marteau , Peter Korsgaard , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] input: Add Nintendo extension controller driver Message-ID: <20110801163823.GA3905@core.coreip.homeip.net> References: <20110527081251.3992.27574.stgit@ponder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, On Mon, Aug 01, 2011 at 05:04:37PM +0100, Grant Likely wrote: > Hi Dmitry, > > Any thoughts on this patch? Can you send it on to Linus? > I thought I responded earlier but apparently not... The issue with the driver is that it pre-registers an input device with a super-set of capabilities instead of waiting until the device is properly identified and registering input device with the exact capabilities. The input policy is that device's stated capabilities should match the physical device (within the constraints of input framework). Thanks. -- Dmitry