mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
	akpm <akpm@linux-foundation.org>,
	torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	J Freyensee <james_p_freyensee@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pti: add missing CONFIG_PCI dependency
Date: Tue, 2 Aug 2011 08:11:29 -0700	[thread overview]
Message-ID: <20110802081129.b84a7bc7.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110802080834.GA9847@osiris.boeblingen.de.ibm.com>

On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> allmodconfig compile fails on s390 because of the new PTI driver:
> 
> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
> 
> Add a 'depends on PCI' statement so it doesn't get compiled.
> 
> Cc: J Freyensee <james_p_freyensee@linux.intel.com>

James has already acked my identical patch.
The problem seems to be that we don't have a drivers/misc/ maintainter to
merge the patch.

Anyway:
Acked-by: Randy Dunlap <rdunlap@xenotime.net>


> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -146,6 +146,7 @@ config PHANTOM
>  
>  config INTEL_MID_PTI
>  	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> +	depends on PCI
>  	default n
>  	help
>  	  The PTI (Parallel Trace Interface) driver directs
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-08-02 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  8:08 Heiko Carstens
2011-08-02 15:11 ` Randy Dunlap [this message]
2011-08-02 16:17   ` J Freyensee
2011-08-02 16:24     ` Greg KH
2011-08-02 16:36       ` J Freyensee
2011-08-03  7:20   ` Geert Uytterhoeven
2011-08-03 16:04     ` J Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802081129.b84a7bc7.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=james_p_freyensee@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®