Re: [PATCH 2/2] cciss: add transport mode attribute to sys

[scameron@beardog.cce.hp.com]

On Wed, Jul 27, 2011 at 04:38:36PM -0500, Joe Handzik wrote:
> From: Joseph Handzik <joseph.t.handzik@beardog.cce.hp.com>
> 
> Signed-off-by: Joseph Handzik <joseph.t.handzik@beardog.cce.hp.com>

looks ok to me.  Ack.

-- steve

> ---
>  .../ABI/testing/sysfs-bus-pci-devices-cciss        |    7 +++++++
>  drivers/block/cciss.c                              |   13 +++++++++++++
>  2 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss b/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> index f5bb0a3..53d99ed 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> @@ -71,3 +71,10 @@ Description:	Value of 1 indicates the controller can honor the reset_devices
>  		a dump device, as kdump requires resetting the device in order
>  		to work reliably.
>  
> +Where:		/sys/bus/pci/devices/<dev>/ccissX/transport_mode
> +Date:		July 2011
> +Kernel Version:	3.0
> +Contact:	iss_storagedev@hp.com
> +Description:	Value of "simple" indicates that the controller has been placed
> +		in "simple mode". Value of "performant" indicates that the
> +		controller has been placed in "performant mode".
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 61f0b5b..6da7ede 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -641,6 +641,18 @@ static ssize_t host_store_rescan(struct device *dev,
>  }
>  static DEVICE_ATTR(rescan, S_IWUSR, NULL, host_store_rescan);
>  
> +static ssize_t host_show_transport_mode(struct device *dev,
> +				 struct device_attribute *attr,
> +				 char *buf)
> +{
> +	struct ctlr_info *h = to_hba(dev);
> +
> +	return snprintf(buf, 20, "%s\n",
> +		h->transMethod & CFGTBL_Trans_Performant ?
> +			"performant" : "simple");
> +}
> +static DEVICE_ATTR(transport_mode, S_IRUGO, host_show_transport_mode, NULL);
> +
>  static ssize_t dev_show_unique_id(struct device *dev,
>  				 struct device_attribute *attr,
>  				 char *buf)
> @@ -813,6 +825,7 @@ static DEVICE_ATTR(usage_count, S_IRUGO, cciss_show_usage_count, NULL);
>  static struct attribute *cciss_host_attrs[] = {
>  	&dev_attr_rescan.attr,
>  	&dev_attr_resettable.attr,
> +	&dev_attr_transport_mode.attr,
>  	NULL
>  };
>