From: Dan Carpenter <error27@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: openssh-server: sshd (<pid>): /proc/<pid>/oom_adj is deprecated, please use /proc/<pid>/oom_score_adj instead.
Date: Wed, 3 Aug 2011 01:58:25 +0300 [thread overview]
Message-ID: <20110802225825.GE3839@shale.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1108011206130.28986@chino.kir.corp.google.com>
Debian testing and Fedora 14 (and 15) are still using an old version
of sshd so in 3.1, I get a popup in gnome that a "kernel crash has
been detected." We made the warning about using old versions of sshd
print a stack trace in be8f684d73d "oom: make deprecated use of
oom_adj more verbose"
[ 20.717978] ------------[ cut here ]------------
[ 20.718003] WARNING: at fs/proc/base.c:1123 oom_adjust_write+0x286/0x2a0()
[ 20.718011] Hardware name: N150P/N210P/N220P
[ 20.718020] sshd (2910): /proc/2910/oom_adj is deprecated, please use /proc/2910/oom_score_adj instead.
[ 20.718029] Modules linked in: fuse brcmsmac(C) brcmutil(C) [last unloaded: scsi_wait_scan]
[ 20.718052] Pid: 2910, comm: sshd Tainted: G C 3.0.0+ #1
[ 20.718059] Call Trace:
[ 20.718076] [<ffffffff81041f9a>] warn_slowpath_common+0x7a/0xb0
[ 20.718090] [<ffffffff81042071>] warn_slowpath_fmt+0x41/0x50
[ 20.718104] [<ffffffff8104d2d5>] ? ns_capable+0x25/0x50
[ 20.718116] [<ffffffff81292e45>] ? kstrtoint+0x15/0x40
[ 20.718129] [<ffffffff81171bf6>] oom_adjust_write+0x286/0x2a0
[ 20.718145] [<ffffffff8111514e>] vfs_write+0xae/0x180
[ 20.718157] [<ffffffff81115465>] sys_write+0x45/0x90
[ 20.718172] [<ffffffff816f143b>] system_call_fastpath+0x16/0x1b
[ 20.718183] ---[ end trace b16d62b4b2b98e24 ]---
There was a warning there for a year, and the distributions have one
more year to upgrade to the newer software, so it's valid to apply
pressure now.
Could we do it in a way that made it more clear that the problem was
an old version of openssh-server and not the kernel? The information
is there, but it's overwhelmed in stack trace spam. Also the kernel
is tainted now because of sshd. Maybe the message could include a
link to a wiki page that told people which version off sshd uses the
new proc file.
regards,
dan carpenter
next parent reply other threads:[~2011-08-02 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110514102014.12739.91576.reportbug@eiffel4.mcfm>
[not found] ` <20110801122537.GA9469@mwanda>
[not found] ` <alpine.DEB.2.00.1108011206130.28986@chino.kir.corp.google.com>
2011-08-02 22:58 ` Dan Carpenter [this message]
2011-08-02 23:14 ` Mihai Moldovan
2011-08-03 4:53 ` David Rientjes
2011-08-03 12:21 ` Alessandro Suardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802225825.GE3839@shale.localdomain \
--to=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®