From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560Ab1HBWLx (ORCPT ); Tue, 2 Aug 2011 18:11:53 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:41321 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755377Ab1HBWLq (ORCPT ); Tue, 2 Aug 2011 18:11:46 -0400 From: Laurent Pinchart To: balbi@ti.com Subject: Re: [PATCH][Resend] Remove unneeded version.h includes (and add where needed) for drivers/usb/ Date: Wed, 3 Aug 2011 00:11:53 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.37-gentoo-r3; KDE/4.6.5; x86_64; ; ) Cc: Jesper Juhl , LKML , trivial@kernel.org, "Greg Kroah-Hartman" , Matthew Dharm , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20110802211923.GB10120@legolas.emea.dhcp.ti.com> In-Reply-To: <20110802211923.GB10120@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108030011.54322.laurent.pinchart@ideasonboard.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, On Tuesday 02 August 2011 23:19:24 Felipe Balbi wrote: > On Mon, Aug 01, 2011 at 11:33:29PM +0200, Jesper Juhl wrote: > > It was pointed out by 'make versioncheck' that linux/version.h was not > > always being included where needed and sometimes included needlessly > > in drivers/usb/. > > This patch fixes up the includes. > > > > For the UVC gadget driver bits, this was ACK'ed by Laurent Pinchart. > > > > Signed-off-by: Jesper Juhl > > Acked-by: Laurent Pinchart > > --- > > > > drivers/usb/gadget/uvc.h | 1 + > > drivers/usb/gadget/uvc_v4l2.c | 1 - > > drivers/usb/storage/realtek_cr.c | 1 - > > 3 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h > > index 5b79194..81971fb 100644 > > --- a/drivers/usb/gadget/uvc.h > > +++ b/drivers/usb/gadget/uvc.h > > @@ -56,6 +56,7 @@ struct uvc_event > > > > #include /* For usb_endpoint_* */ > > #include > > #include > > > > +#include > > does uvc.h really needs ?? Laurent ? uvc.h has #define DRIVER_VERSION_NUMBER KERNEL_VERSION(0, 1, 0) This is used in drivers/usb/gadget/uvc_v4l2.c only. As the uvc gadget driver lives in-tree, the best fix is probably to remove DRIVER_VERSION_NUMBER completely, and replace it with LINUX_VERSION_CODE where it is used. -- Regards, Laurent Pinchart