From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753043Ab1HCIPk (ORCPT ); Wed, 3 Aug 2011 04:15:40 -0400 Received: from mga03.intel.com ([143.182.124.21]:52754 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824Ab1HCIPf (ORCPT ); Wed, 3 Aug 2011 04:15:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,309,1309762800"; d="scan'208";a="34595434" Date: Wed, 3 Aug 2011 11:15:59 +0300 From: Mika Westerberg To: H Hartley Sweeten Cc: Linux Kernel , "linux-watchdog@vger.kernel.org" , "wim@iguana.be" Subject: Re: [RFC PATCH] watchdog: ep93xx: Use the WatchDog Timer Driver Core. Message-ID: <20110803081559.GI13218@intel.com> References: <201108011357.24745.hartleys@visionengravers.com> <20110802091640.GF13218@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2011 at 11:55:36AM -0500, H Hartley Sweeten wrote: > >> -static const struct watchdog_info ident = { > >> - .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE, > >> - .identity = "EP93xx Watchdog", > >> +static const struct watchdog_info ep93xx_wdt_ident = { > >> + .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE, > >> + .identity = "EP93xx Watchdog", > >> }; One more thing I noticed: you should add WDIOF_KEEPALIVEPING to the options field. Otherwise it doesn't support ioctl(..., WDIOC_KEEPALIVE) which was supported in the original driver.