From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577Ab1HCKEF (ORCPT ); Wed, 3 Aug 2011 06:04:05 -0400 Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:53271 "EHLO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753197Ab1HCKD5 (ORCPT ); Wed, 3 Aug 2011 06:03:57 -0400 Date: Wed, 3 Aug 2011 13:03:52 +0300 From: Felipe Balbi To: Laurent Pinchart Cc: balbi@ti.com, Jesper Juhl , LKML , trivial@kernel.org, Greg Kroah-Hartman , Matthew Dharm , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH][Resend] Remove unneeded version.h includes (and add where needed) for drivers/usb/ Message-ID: <20110803100351.GB11080@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <201108030011.54322.laurent.pinchart@ideasonboard.com> <20110802225041.GA10284@legolas.emea.dhcp.ti.com> <201108031018.23654.laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <201108031018.23654.laurent.pinchart@ideasonboard.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Aug 03, 2011 at 10:18:23AM +0200, Laurent Pinchart wrote: > On Wednesday 03 August 2011 00:50:42 Felipe Balbi wrote: > > On Wed, Aug 03, 2011 at 12:11:53AM +0200, Laurent Pinchart wrote: > > > On Tuesday 02 August 2011 23:19:24 Felipe Balbi wrote: > > > > On Mon, Aug 01, 2011 at 11:33:29PM +0200, Jesper Juhl wrote: > > > > > It was pointed out by 'make versioncheck' that linux/version.h was > > > > > not always being included where needed and sometimes included > > > > > needlessly in drivers/usb/. > > > > > This patch fixes up the includes. > > > > >=20 > > > > > For the UVC gadget driver bits, this was ACK'ed by Laurent Pincha= rt. > > > > >=20 > > > > > Signed-off-by: Jesper Juhl > > > > > Acked-by: Laurent Pinchart > > > > > --- > > > > >=20 > > > > > drivers/usb/gadget/uvc.h | 1 + > > > > > drivers/usb/gadget/uvc_v4l2.c | 1 - > > > > > drivers/usb/storage/realtek_cr.c | 1 - > > > > > 3 files changed, 1 insertions(+), 2 deletions(-) > > > > >=20 > > > > > diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h > > > > > index 5b79194..81971fb 100644 > > > > > --- a/drivers/usb/gadget/uvc.h > > > > > +++ b/drivers/usb/gadget/uvc.h > > > > > @@ -56,6 +56,7 @@ struct uvc_event > > > > >=20 > > > > > #include /* For usb_endpoint_* */ > > > > > #include > > > > > #include > > > > >=20 > > > > > +#include > > > >=20 > > > > does uvc.h really needs ?? Laurent ? > > >=20 > > > uvc.h has > > >=20 > > > #define DRIVER_VERSION_NUMBER KERNEL_VERSION(0, 1, = 0) > > >=20 > > > This is used in drivers/usb/gadget/uvc_v4l2.c only. > > >=20 > > > As the uvc gadget driver lives in-tree, the best fix is probably to > > > remove DRIVER_VERSION_NUMBER completely, and replace it with > > > LINUX_VERSION_CODE where it is used. > >=20 > > yeah, I can agree with that, but do you need a MODULE_VERSION() anyway ? > > Would it be better to just remove the MODULE_VERSION altogether as > > there's no real benefit from having it ? >=20 > DRIVER_VERSION_NUMBER isn't used as a MODULE_VERSION() argument. The driv= er=20 > uses it to report its version through the V4L2 API. ahaa, ok. fine by me then. --=20 balbi --l76fUT7nc3MelDdI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOOR0HAAoJEAv8Txj19kN1kPQIAKS33ve3bW9x5DEzn4F8yrs/ aHOj89y8D84IQkvcUPW7pOpjieFrJmXKm+ygvvE5kOVUqJZcL9Kc0tul+fw83s29 q6aYDR/ygdnnWgEwrcWkm9s6iMB5hMXQQYAhYkXRBHJDJhAgj/lBG44cHja8ThPO 39s1NlSBVHavjx8zE09PC52sW/GQ4ixnIyY/WS0U4BsO6rIfUE63GGKiLgSA0Puy BeWgPmOZRl2VgKEWty9rbdvlk11w4v7+9ggiGXEteOY1PTSmeFiS6Ilv2AYIl8Wl u/d0q3MfzH8z70KCtWhiCm7du9MpEq4X1AUwSuoDTFAsytqjUFZmQIpyoYx9k5M= =qgQa -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--