From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755337Ab1HCS5x (ORCPT ); Wed, 3 Aug 2011 14:57:53 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:58325 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755197Ab1HCS5s (ORCPT ); Wed, 3 Aug 2011 14:57:48 -0400 Date: Wed, 3 Aug 2011 20:56:34 +0200 From: Ingo Molnar To: Randy Dunlap Cc: Stephen Rothwell , Leendert van Doorn , linux-next@vger.kernel.org, LKML , James Morris , tpmdd-devel@lists.sourceforge.net, Linus Torvalds , Andrew Morton Subject: Re: [PATCH -next] tpm_tis: fix build when ACPI is not enabled Message-ID: <20110803185634.GA16988@elte.hu> References: <20110727141151.d31e3da6a8d21a255473293c@canb.auug.org.au> <20110727114211.18be47cf.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110727114211.18be47cf.rdunlap@xenotime.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Randy Dunlap wrote: > From: Randy Dunlap > > Fix tpm_tis.c build when CONFIG_ACPI is not enabled by providing > a stub function. Fixes many build errors/warnings: > > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr' > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr' > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union > drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name' > drivers/char/tpm/tpm_tis.c:90: error: dereferencing pointer to incomplete type > > Signed-off-by: Randy Dunlap > Cc: Leendert van Doorn > --- > drivers/char/tpm/tpm_tis.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) FYI, this build breakage is now upstream as well and triggers easily. This fix was sent 5+ days ago (with still no reply to it), a day after this fix the security tree pull request was sent with this known build breakage included, so the bug is still unfixed upstream and no fix is in the pipeline AFAICS. Got lost? Thanks, Ingo