From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754822Ab1HDXKP (ORCPT ); Thu, 4 Aug 2011 19:10:15 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:53677 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754654Ab1HDXKL (ORCPT ); Thu, 4 Aug 2011 19:10:11 -0400 Date: Thu, 04 Aug 2011 16:08:01 -0700 (PDT) Message-Id: <20110804.160801.410790028578990791.davem@davemloft.net> To: robherring2@gmail.com Cc: davidb@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of/address: Add of_iomap_nocache From: David Miller In-Reply-To: <4E3AC05A.1070208@gmail.com> References: <1312451629-28036-1-git-send-email-davidb@codeaurora.org> <20110804.031254.836213129500890372.davem@davemloft.net> <4E3AC05A.1070208@gmail.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 04 Aug 2011 16:08:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rob Herring Date: Thu, 04 Aug 2011 10:52:58 -0500 > On 08/04/2011 05:12 AM, David Miller wrote: >> From: David Brown >> Date: Thu, 4 Aug 2011 02:53:49 -0700 >> >>> Add uncached mappings from devicetree nodes similar to regular io >>> mappings. >>> >>> Signed-off-by: David Brown >> >> You'll need to add a sparc implementation. > > Sparc just defines ioremap_nocache to ioremap, so is that really needed? Yes because if someone uses this of_iomap_nocache() in a driver the sparc build is going to fail, we need as least the define to make it equal to of_iomap() as David did in his follow-on patch.