From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305Ab1HDHeH (ORCPT ); Thu, 4 Aug 2011 03:34:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49497 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276Ab1HDHeA (ORCPT ); Thu, 4 Aug 2011 03:34:00 -0400 Date: Thu, 4 Aug 2011 09:33:57 +0200 From: Michal Hocko To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "nishimura@mxp.nes.nec.co.jp" Subject: Re: [BUGFIX][PATCH] memcg: fix oom schedule_timeout Message-ID: <20110804073357.GC31039@tiehlicka.suse.cz> References: <20110803121532.1ab8d76c.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110803121532.1ab8d76c.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 03-08-11 12:15:32, KAMEZAWA Hiroyuki wrote: > > This patch is onto the latest mmotm. > > == > Before calling schedule_timeout(), task state should be changed. > > Signed-off-by: KAMEZAWA Hiroyuki Looks good. Acked-by: Michal Hocko > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: mmotm-Aug3/mm/memcontrol.c > =================================================================== > --- mmotm-Aug3.orig/mm/memcontrol.c > +++ mmotm-Aug3/mm/memcontrol.c > @@ -2005,7 +2005,7 @@ bool mem_cgroup_handle_oom(struct mem_cg > if (test_thread_flag(TIF_MEMDIE) || fatal_signal_pending(current)) > return false; > /* Give chance to dying process */ > - schedule_timeout(1); > + schedule_timeout_uninterruptible(1); > return true; > } > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic