From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067Ab1HDUEr (ORCPT ); Thu, 4 Aug 2011 16:04:47 -0400 Received: from mailrelay003.isp.belgacom.be ([195.238.6.53]:58030 "EHLO mailrelay003.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621Ab1HDUEl (ORCPT ); Thu, 4 Aug 2011 16:04:41 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAEL5Ok5R8j0b/2dsb2JhbABDp2l4gUABAQQBOhweBRAIA0YUJQMhh38CwWQOhjQEo2E Date: Thu, 4 Aug 2011 22:04:39 +0200 From: Wim Van Sebroeck To: H Hartley Sweeten Cc: Mika Westerberg , Linux Kernel , "linux-watchdog@vger.kernel.org" , "mika.westerberg@linux.intel.com" Subject: Re: [RFC PATCH v2] watchdog: ep93xx: Use the WatchDog Timer Driver Core. Message-ID: <20110804200439.GU4227@infomag.iguana.be> References: <201108031021.26620.hartleys@visionengravers.com> <20110804181244.GA2445@mwesterb-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, > > BTW, now that the driver uses watchdog core should we also select > > WATCHDOG_CORE in the Kconfig? If it is not enabled we get: > > > > drivers/built-in.o: In function `ep93xx_wdt_init': > > clkdev.c:(.init.text+0x2bd8): undefined reference to > > `watchdog_register_device' > > make: *** [.tmp_vmlinux1] Error 1 > > Of course. > > I wasn't sure how Wim wanted to handle this. I see two ways of doing it > in the Kconfig. > > 1) Each driver config option has a select WATCHDOG_CORE if it is required. > > Pro: all the watchdog drivers (that are available) are displayed > Con: each driver needs to add the select if needed > Side-effect: the WATCHDOG_CORE option could (should) be a hidden option > > 2) Separate the watchdog drivers into groups that need the WATCHDOG_CORE > and those that don't then put a if WATCHDOG_CORE/endif around the ones > that need it. > > Pro: keeps the Kconfig clean > Con: the drivers that use WATCHDOG_CORE are not displayed unless the > option is selected > Con: defconfigs probably will need to be updated to select WATCHDOG_CORE > > Wim, do you have any opinion on this? I allready discussed this with Wolfram a few weeks ago. Since we don't want defconfigs to change, the best option is to: 1) use 'select WATCHDOG_CORE' during conversion of the drivers. 2) remove CONFIG_WATCHDOG_CORE and replace it by CONFIG_WATCHDOG in a later stage so that the core API becomes the user-space layer for all watchdog device drivers.This so that we can support multiple watchdogs in the future and to make sure that we keep having a consistent user-space interface. Kind regards, Wim.