From: Tobias Klauser <tklauser@distanz.ch>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Colin Cross <ccross@android.com>,
John Bonesio <bones@secretlab.ca>,
"Jean Delvare (PC drivers, core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-i2c@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
"Sam Ravnborg sam"@ravnborg.org
Subject: Re: [RFC][PATCH] of: add a dummy implementation of of_get_property() in of.h
Date: Fri, 5 Aug 2011 11:05:14 +0200 [thread overview]
Message-ID: <20110805090514.GA17391@distanz.ch> (raw)
In-Reply-To: <1312534574.18064.2.camel@phoenix>
On 2011-08-05 at 10:56:14 +0200, Axel Lin <axel.lin@gmail.com> wrote:
> Then we can avoid having #ifdef CONFIG_OF splattered around the place
> calling of_get_property(), it leads to errors.
You shouldn't redefine of_get_property in the driver. Rather add a
wrapper function to the driver which will extract the device tree
information in CONFIG_OF is enabled and which will just return -ENODEV
if CONFIG_OF is not set.
Cheers
Tobias
prev parent reply other threads:[~2011-08-05 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 8:56 Axel Lin
2011-08-05 9:05 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805090514.GA17391@distanz.ch \
--to=tklauser@distanz.ch \
--cc="Sam Ravnborg sam"@ravnborg.org \
--cc=axel.lin@gmail.com \
--cc=ben-linux@fluff.org \
--cc=bones@secretlab.ca \
--cc=ccross@android.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®