From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475Ab1HFGtu (ORCPT ); Sat, 6 Aug 2011 02:49:50 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:47927 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010Ab1HFGtr (ORCPT ); Sat, 6 Aug 2011 02:49:47 -0400 Date: Sat, 6 Aug 2011 08:48:47 +0200 From: Ingo Molnar To: Frederic Weisbecker Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra , Arnaldo Carvalho de Melo , Borislav Petkov , Arjan van de Ven Subject: Re: [RFC][PATCH 0/8] Having perf use libparsevent.a Message-ID: <20110806064847.GB13220@elte.hu> References: <20110805205921.909038487@goodmis.org> <20110805212409.GA21114@elte.hu> <20110806004342.GG22164@somewhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110806004342.GG22164@somewhere> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > On Fri, Aug 05, 2011 at 11:24:09PM +0200, Ingo Molnar wrote: > > > > * Steven Rostedt wrote: > > > > > By keeping the code separate from perf, made the transition from > > > trace-cmd to tools much easier. I've wasted too many days trying to > > > get other ways working, and I don't want to rewrite perf to do so. > > > > But we want to move tools together, not further apart. Every code > > activity i see from you is trying to tear apart instrumentation > > tooling - while previously you agreed that it should be unified. So > > why not do tools/perf/lib/ as you agreed before? > > > > I'm really not interested in seeing the libdrm/libdri mess repeated. > > Libraries have their uses when there's some very important external > > interface, but here it's actively harmful as it complicates and > > hardcodes APIs into ABIs that are clearly not finished yet. > > > > Really, lets not be stupid here. > > > > Thanks, > > > > Ingo > > The trace events format is a general interface that not only perf > and trace-cmd use but also powertop and pytimechart, and may be > others? > > And given the breakage we had with powertop, for example, that > broke because it was relying on an ad-hoc static layout of the > trace event, or pytimechart that relies(ed?) on the event string > output, I think that library is needed outside perf. That is why i suggested libperf.so - this will handle the cases you mention, plus any future case - while still allow more flexible code sharing between libperf and the perf tools themselves. Thanks, Ingo