From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385Ab1HFIDg (ORCPT ); Sat, 6 Aug 2011 04:03:36 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:49673 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129Ab1HFID2 (ORCPT ); Sat, 6 Aug 2011 04:03:28 -0400 Date: Sat, 6 Aug 2011 10:03:23 +0200 From: Tejun Heo To: Rabin Vincent Cc: linux-kernel@vger.kernel.org, Andrew Morton , x86@kernel.org Subject: Re: [PATCH] stop_machine: build unconditionally if SMP Message-ID: <20110806080323.GB23937@htj.dyndns.org> References: <1312614073-11516-1-git-send-email-rabin@rab.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312614073-11516-1-git-send-email-rabin@rab.in> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Aug 06, 2011 at 12:31:13PM +0530, Rabin Vincent wrote: > stop_machine() is built for "(SMP && MODULE_UNLOAD) || HOTPLUG_CPU", but > is also used by the timekeeping code, the mm code, ftrace, and couple of > things in arch/*. Just build it if we're using SMP, like it's already > the case on x86. > > Cc: x86@kernel.org > Cc: Tejun Heo > Signed-off-by: Rabin Vincent Yeah, looks good to me. Acked-by: Tejun Heo Andrew, can you please route this one? Thank you. -- tejun