From: Felipe Balbi <balbi@ti.com>
To: Per Forlin <per.forlin@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-dev@lists.linaro.org,
Mian Yousaf KAUKAB <mian.yousaf.kaukab@stericsson.com>
Subject: Re: [PATCH] usb: musb: ux500: optimize DMA callback routine
Date: Mon, 8 Aug 2011 13:01:06 +0300 [thread overview]
Message-ID: <20110808100105.GA31536@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1312792358-2445-1-git-send-email-per.forlin@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hi,
On Mon, Aug 08, 2011 at 10:32:38AM +0200, Per Forlin wrote:
[snip]
> -/* Work function invoked from DMA callback to handle rx transfers. */
> -static void ux500_rx_work(struct work_struct *data)
> +void ux500_dma_callback(void *private_data)
> {
> - struct ux500_dma_channel *ux500_channel = container_of(data,
> - struct ux500_dma_channel, channel_work);
> + struct dma_channel *channel = (struct dma_channel *)private_data;
you don't need to explicitly cast a void pointer, please remove that.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-08-08 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 8:32 Per Forlin
2011-08-08 10:01 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808100105.GA31536@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mian.yousaf.kaukab@stericsson.com \
--cc=per.forlin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®