From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, autofs@linux.kernel.org,
David Howells <dhowells@redhat.com>, Ian Kent <raven@themaw.net>
Subject: [PATCH] autofs4: Use no_printk() for no-op DPRINTK() and use __VA_ARGS__ too
Date: Mon, 08 Aug 2011 16:10:38 +0100 [thread overview]
Message-ID: <20110808151038.17366.38130.stgit@warthog.procyon.org.uk> (raw)
Use no_printk() for autofs's no-op DPRINTK() to prevent unused statements from
becoming accidentally obsolete, and use __VA_ARGS__ too as that's the standard
way.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/autofs4/autofs_i.h | 10 +++++++---
fs/autofs4/waitq.c | 3 ++-
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index 475f9c5..c3a419f 100644
--- a/fs/autofs4/autofs_i.h
+++ b/fs/autofs4/autofs_i.h
@@ -40,13 +40,17 @@
/* #define DEBUG */
#ifdef DEBUG
-#define DPRINTK(fmt, args...) \
+#define DPRINTK(fmt, ...) \
do { \
printk(KERN_DEBUG "pid %d: %s: " fmt "\n", \
- current->pid, __func__, ##args); \
+ current->pid, __func__, ##__VA_ARGS__); \
} while (0)
#else
-#define DPRINTK(fmt, args...) do {} while (0)
+#define DPRINTK(fmt, ...) \
+do { \
+ no_printk(KERN_DEBUG "pid %d: %s: " fmt "\n", \
+ current->pid, __func__, ##__VA_ARGS__); \
+} while (0)
#endif
#define AUTOFS_WARN(fmt, args...) \
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 2543598..6313a0d 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -104,7 +104,8 @@ static void autofs4_notify_daemon(struct autofs_sb_info *sbi,
size_t pktsz;
DPRINTK("wait id = 0x%08lx, name = %.*s, type=%d",
- wq->wait_queue_token, wq->name.len, wq->name.name, type);
+ (unsigned long)wq->wait_queue_token,
+ wq->name.len, wq->name.name, type);
memset(&pkt,0,sizeof pkt); /* For security reasons */
next reply other threads:[~2011-08-08 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 15:10 David Howells [this message]
2011-08-08 16:09 ` Linus Torvalds
2011-08-09 0:56 ` [PATCH] autofs4: Use pr_fmt and pr_<level> Joe Perches
2011-08-08 16:11 ` [PATCH] autofs4: Use no_printk() for no-op DPRINTK() and use __VA_ARGS__ too Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808151038.17366.38130.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®