mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: randy.dunlap@oracle.com, dtor@mail.ru, dmitry.torokhov@gmail.com,
	linaro-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v1 08/11] Touch: DA9052 touchscreen driver
Date: Tue, 9 Aug 2011 15:45:28 +0200	[thread overview]
Message-ID: <20110809134528.GB31042@pengutronix.de> (raw)
In-Reply-To: <1310633890.284.90.camel@L-0532.kpit.com>

Hi Ashish,

On Thu, Jul 14, 2011 at 02:28:10PM +0530, ashishj3 wrote:
> This driver add support for DA9052 4-wire resistive ADC interfaced touchscreen
> controller.
> 
> DA9052 is a MFD therefore this driver depends on DA9052 core driver for core
> functionalities.
> 
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> ---
>  drivers/input/touchscreen/Kconfig      |    7 +
>  drivers/input/touchscreen/Makefile     |    1 +
>  drivers/input/touchscreen/da9052_tsi.c |  489 ++++++++++++++++++++++++++++++++
>  3 files changed, 497 insertions(+), 0 deletions(-)
>  create mode 100755 drivers/input/touchscreen/da9052_tsi.c
[snip]
> +	ret = da9052_clear_bits(da9052, DA9052_GPIO_4_5_REG, 0x33);
> +	if (ret < 0)
> +		return -EIO;
> +
> +	ret = da9052_clear_bits(da9052, DA9052_GPIO_6_7_REG, 0x33);

Those two register defines are missing in your posted MFD driver headerfile "reg.h".

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2011-08-09 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14  8:58 ashishj3
2011-07-25 11:43 ` ashishj3
2011-07-25 11:46 ` ashishj3
2011-07-26  2:39 ` Dmitry Torokhov
2011-08-09 13:45 ` Michael Grzeschik [this message]
2011-08-09 13:59 ` [RFC PATCH] da9052_tsi: remove fifo and use delayed work Michael Grzeschik
2011-08-12  7:26   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110809134528.GB31042@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@mail.ru \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®