mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Per Forlin <per.forlin@linaro.org>, Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linaro-dev@lists.linaro.org,
	Michal Nazarewicz <mina86@mina86.com>
Subject: Re: [PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size
Date: Tue, 9 Aug 2011 17:51:55 +0300	[thread overview]
Message-ID: <20110809145154.GA32212@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1108090957020.1949-100000@iolanthe.rowland.org>

[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]

Hi,

On Tue, Aug 09, 2011 at 09:57:19AM -0400, Alan Stern wrote:
> On Mon, 8 Aug 2011, Per Forlin wrote:
> 
> > FSG_NUM_BUFFERS is set to 2 as default.
> > Usually 2 buffers are enough to establish a good buffering pipeline.
> > The number may be increased in order to compensate a for bursty VFS
> > behaviour.
> > 
> > Here follows a description of system that may require more than
> > 2 buffers.
> >  * CPU ondemand governor active
> >  * latency cost for wake up and/or frequency change
> >  * DMA for IO
> > 
> > Use case description.
> >  * Data transfer from MMC via VFS to USB.
> >  * DMA shuffles data from MMC and to USB.
> >  * The CPU wakes up every now and then to pass data in and out from VFS,
> >    which cause the bursty VFS behaviour.
> > 
> > Test set up
> >  * Running dd on the host reading from the mass storage device
> >  * cmdline: dd if=/dev/sdb of=/dev/null bs=4k count=$((256*100))
> >  * Caches are dropped on the host and on the device before each run
> > 
> > Measurements on a Snowball board with ondemand_govenor active.
> > 
> > FSG_NUM_BUFFERS 2
> > 104857600 bytes (105 MB) copied, 5.62173 s, 18.7 MB/s
> > 104857600 bytes (105 MB) copied, 5.61811 s, 18.7 MB/s
> > 104857600 bytes (105 MB) copied, 5.57817 s, 18.8 MB/s
> > 
> > FSG_NUM_BUFFERS 4
> > 104857600 bytes (105 MB) copied, 5.26839 s, 19.9 MB/s
> > 104857600 bytes (105 MB) copied, 5.2691 s, 19.9 MB/s
> > 104857600 bytes (105 MB) copied, 5.2711 s, 19.9 MB/s
> > 
> > There may not be one optimal number for all boards. This is why
> > the number is added to Kconfig.
> > 
> > Signed-off-by: Per Forlin <per.forlin@linaro.org>
> > Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Thanks.

Hijacking this thread for a small note. I'll be back on applying patches
this friday. Until then I'll be focussed on some other issues which
we're tracking down.

Thanks for understanding ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-08-09 14:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 21:43 Per Forlin
2011-08-09 13:57 ` Alan Stern
2011-08-09 14:51   ` Felipe Balbi [this message]
2011-08-12  9:20 ` Felipe Balbi
2011-08-12 15:49   ` Alan Stern
2011-08-17  9:50     ` Per Forlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110809145154.GA32212@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=gregkh@suse.de \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=per.forlin@linaro.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®