From: Marc Dietrich <Marc.Dietrich@ap.physik.uni-giessen.de>
To: Stephen Warren <swarren@nvidia.com>
Cc: Colin Cross <ccross@android.com>,
Erik Gilling <konkers@android.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Tegra: Force PORT_TEGRA as the UART type
Date: Tue, 9 Aug 2011 20:26:02 +0200 [thread overview]
Message-ID: <201108092026.04726.marc.dietrich@ap.physik.uni-giessen.de> (raw)
In-Reply-To: <1312837265-11984-1-git-send-email-swarren@nvidia.com>
Hi Stephen,
Am Montag 08 August 2011, 23:01:05 schrieb Stephen Warren:
> 8250.c recently gained an explicit PORT_TEGRA port type. Specifically
> request this in all Tegra boards' UART platform data.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Tested the paz00 part and found no issues. So for board-paz00:
Acked-By: Marc Dietrich <marvin24@gmx.de>
> ---
> NOTE: This depends on "[PATCH 1/5] ARM: tegra: paz00: add support serial
> port on JP1", which was recently posted by Marc Dietrich, since that added
> one of the platform data array entries being modified by this patch.
>
> arch/arm/mach-tegra/board-harmony.c | 3 ++-
> arch/arm/mach-tegra/board-paz00.c | 6 ++++--
> arch/arm/mach-tegra/board-seaboard.c | 3 ++-
> arch/arm/mach-tegra/board-trimslice.c | 3 ++-
> 4 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-harmony.c b/arch/arm/mach-tegra/board-harmony.c
> index f528a5a..987dab5 100644
> --- a/arch/arm/mach-tegra/board-harmony.c
> +++ b/arch/arm/mach-tegra/board-harmony.c
> @@ -49,7 +49,8 @@ static struct plat_serial8250_port debug_uart_platform_data[] = {
> .membase = IO_ADDRESS(TEGRA_UARTD_BASE),
> .mapbase = TEGRA_UARTD_BASE,
> .irq = INT_UARTD,
> - .flags = UPF_BOOT_AUTOCONF,
> + .flags = UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
> + .type = PORT_TEGRA,
> .iotype = UPIO_MEM,
> .regshift = 2,
> .uartclk = 216000000,
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index b7494c2..c6a6d82 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -49,7 +49,8 @@ static struct plat_serial8250_port debug_uart_platform_data[] = {
> .membase = IO_ADDRESS(TEGRA_UARTA_BASE),
> .mapbase = TEGRA_UARTA_BASE,
> .irq = INT_UARTA,
> - .flags = UPF_BOOT_AUTOCONF,
> + .flags = UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
> + .type = PORT_TEGRA,
> .iotype = UPIO_MEM,
> .regshift = 2,
> .uartclk = 216000000,
> @@ -58,7 +59,8 @@ static struct plat_serial8250_port debug_uart_platform_data[] = {
> .membase = IO_ADDRESS(TEGRA_UARTD_BASE),
> .mapbase = TEGRA_UARTD_BASE,
> .irq = INT_UARTD,
> - .flags = UPF_BOOT_AUTOCONF,
> + .flags = UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
> + .type = PORT_TEGRA,
> .iotype = UPIO_MEM,
> .regshift = 2,
> .uartclk = 216000000,
> diff --git a/arch/arm/mach-tegra/board-seaboard.c b/arch/arm/mach-tegra/board-seaboard.c
> index 237a94a..25446df 100644
> --- a/arch/arm/mach-tegra/board-seaboard.c
> +++ b/arch/arm/mach-tegra/board-seaboard.c
> @@ -44,7 +44,8 @@
> static struct plat_serial8250_port debug_uart_platform_data[] = {
> {
> /* Memory and IRQ filled in before registration */
> - .flags = UPF_BOOT_AUTOCONF,
> + .flags = UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
> + .type = PORT_TEGRA,
> .iotype = UPIO_MEM,
> .regshift = 2,
> .uartclk = 216000000,
> diff --git a/arch/arm/mach-tegra/board-trimslice.c b/arch/arm/mach-tegra/board-trimslice.c
> index 89a6d2a..91875b9 100644
> --- a/arch/arm/mach-tegra/board-trimslice.c
> +++ b/arch/arm/mach-tegra/board-trimslice.c
> @@ -46,7 +46,8 @@ static struct plat_serial8250_port debug_uart_platform_data[] = {
> .membase = IO_ADDRESS(TEGRA_UARTA_BASE),
> .mapbase = TEGRA_UARTA_BASE,
> .irq = INT_UARTA,
> - .flags = UPF_BOOT_AUTOCONF,
> + .flags = UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
> + .type = PORT_TEGRA,
> .iotype = UPIO_MEM,
> .regshift = 2,
> .uartclk = 216000000,
>
next prev parent reply other threads:[~2011-08-09 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 21:01 Stephen Warren
2011-08-09 18:26 ` Marc Dietrich [this message]
2011-08-09 19:30 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108092026.04726.marc.dietrich@ap.physik.uni-giessen.de \
--to=marc.dietrich@ap.physik.uni-giessen.de \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®