mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH] Staging: comedi: fix printk() issue in das6402.c
Date: Wed, 10 Aug 2011 11:04:49 +0300	[thread overview]
Message-ID: <20110810080449.GC3706@shale.localdomain> (raw)
In-Reply-To: <1312954420-3470-1-git-send-email-ravishankarkm32@gmail.com>

dev_printk() can't be used with KERN_CONT.  It always prints:

        return printk("%s%s %s: %pV",
	                      level, dev_driver_string(dev), dev_name(dev), vaf);

That's perhaps a problem in dev_printk() which should be changed.  I
don't feel strongly either way...

regards,
dan carpenter


  reply	other threads:[~2011-08-10  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH]Staging: comedi:fix printk() issue in das6402.c>
2011-08-10  5:33 ` Ravishankar
2011-08-10  8:04   ` Dan Carpenter [this message]
2011-08-10 10:06 ` [PATCH v2] " Ravishankar
     [not found] <[PATCH]Staging: Comedi: fix printk issue in das6402.c>
2011-07-23  6:13 ` [PATCH] Staging: comedi: fix printk " Ravishankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810080449.GC3706@shale.localdomain \
    --to=error27@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi.shankar@greenturtles.in \
    --cc=ravishankarkm32@gmail.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®