From: Manohar Vanga <manohar.vanga@cern.ch>
To: Martyn Welch <martyn.welch@ge.com>
Cc: <gregkh@suse.de>, <cota@braap.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] staging: vme: allow explicit assignment of bus numbers
Date: Wed, 10 Aug 2011 12:41:43 +0200 [thread overview]
Message-ID: <20110810104143.GA14060@becoht-mvanga> (raw)
In-Reply-To: <4E425725.7080305@ge.com>
Hey Martyn,
> I'm sorry, I'm still simply not convinced by this patch:
>
> 1) For a single bus driver (i.e. in the situation where we have 2 bridges of
> the same type), the numbering of the buses is still dependent on the order
> that they are found in the scan.
Yes this is still a bug. But this patch doesn't address this case.
> 2) If the bridge drivers are loaded as modules, I have a feeling they will be
> loaded sequentially and therefore the order of the bridges would only change
> if the order of the loading of the drivers changed.
And this is a major problem when it comes to multiple bridges of differing
types. What I'm saying is that this patch simply fixes this one problematic
case. We can move this out as soon as we have a more robust implementation.
As of now however, I think applying this is useful as we have a decent
workaround to the problem. If you want I can make the fact of it being
applicable only to cases with differing bridges explicit in the commit
message.
--
/manohar
next prev parent reply other threads:[~2011-08-10 10:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 9:33 [PATCH 0/6] [RESEND] VME framework fixes Manohar Vanga
2011-08-10 9:33 ` [PATCH 1/6] staging: vme: allow explicit assignment of bus numbers Manohar Vanga
2011-08-10 10:02 ` Martyn Welch
2011-08-10 10:41 ` Manohar Vanga [this message]
2011-08-10 12:50 ` Martyn Welch
2011-08-23 22:06 ` Greg KH
2011-08-10 9:33 ` [PATCH 2/6] staging: vme: make [alloc|free]_consistent bridge specific Manohar Vanga
2011-08-10 10:04 ` Martyn Welch
2011-08-10 13:24 ` Dan Carpenter
2011-08-10 13:12 ` Joe Perches
2011-08-10 13:34 ` Martyn Welch
2011-08-10 13:51 ` Joe Perches
2011-08-10 13:55 ` Martyn Welch
2011-08-10 14:30 ` Joe Perches
2011-08-10 14:33 ` Martyn Welch
2011-08-10 9:33 ` [PATCH 3/6] staging: vme: keep track of registered buses Manohar Vanga
2011-08-10 10:06 ` Martyn Welch
2011-08-10 9:33 ` [PATCH 4/6] staging: vme: add functions for bridge module refcounting Manohar Vanga
2011-08-10 10:09 ` Martyn Welch
2011-08-10 19:14 ` Emilio G. Cota
2011-08-10 9:33 ` [PATCH 5/6] staging: vme: add struct vme_dev for VME devices Manohar Vanga
2011-08-10 10:14 ` Martyn Welch
2011-08-10 10:33 ` Manohar Vanga
2011-08-10 9:33 ` [PATCH 6/6] staging: vme: make match() driver specific to improve non-VME64x support Manohar Vanga
2011-08-10 10:18 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810104143.GA14060@becoht-mvanga \
--to=manohar.vanga@cern.ch \
--cc=cota@braap.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®