From: Chris Metcalf <cmetcalf@tilera.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] nfs: fix a couple of minor portability issues
Date: Wed, 10 Aug 2011 13:56:28 -0400 [thread overview]
Message-ID: <201108101803.p7AI36eV008484@farm-0023.internal.tilera.com> (raw)
Building on tilepro revealed two minor portability issues: the
blocklayout.c file used prefetchw() without #include <linux/prefetch.h>,
and the nfs4filelayout.c file used do_div() on an s64 not a u64.
This change fixes those two issues so the NFS code builds on tilepro.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
fs/nfs/blocklayout/blocklayout.c | 1 +
fs/nfs/nfs4filelayout.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index e56564d..9561c8f 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -36,6 +36,7 @@
#include <linux/namei.h>
#include <linux/bio.h> /* struct bio */
#include <linux/buffer_head.h> /* various write calls */
+#include <linux/prefetch.h>
#include "blocklayout.h"
diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index e8915d4..6976a72 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -48,13 +48,13 @@ filelayout_get_dense_offset(struct nfs4_filelayout_segment *flseg,
loff_t offset)
{
u32 stripe_width = flseg->stripe_unit * flseg->dsaddr->stripe_count;
- u64 tmp;
+ u64 tmp, uoff;
offset -= flseg->pattern_offset;
- tmp = offset;
+ tmp = uoff = offset;
do_div(tmp, stripe_width);
- return tmp * flseg->stripe_unit + do_div(offset, flseg->stripe_unit);
+ return tmp * flseg->stripe_unit + do_div(uoff, flseg->stripe_unit);
}
/* This function is used by the layout driver to calculate the
--
1.6.5.2
next reply other threads:[~2011-08-10 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 17:56 Chris Metcalf [this message]
2011-08-10 22:02 ` Boaz Harrosh
2011-08-11 13:26 ` Chris Metcalf
2011-08-11 18:27 ` Boaz Harrosh
2011-08-11 19:32 ` [PATCH v2] nfs: fix a minor do_div portability issue Chris Metcalf
2011-08-11 20:54 ` [PATCH v3] " Boaz Harrosh
2011-08-11 15:17 ` [PATCH] nfs: fix a couple of minor portability issues Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108101803.p7AI36eV008484@farm-0023.internal.tilera.com \
--to=cmetcalf@tilera.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®