mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Tracey Dent <tdent48227@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@suse.de
Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
Date: Thu, 11 Aug 2011 09:45:20 -0700	[thread overview]
Message-ID: <20110811094520.4ee7819f.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110811162306.GA30710@tj-desktop>

On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:

> When you try to build INTEL_MID_PTI without having PCI
> enabled. It fails like this-
> 
>  CC [M]  drivers/misc/pti.o
>  drivers/misc/pti.c: In function ‘pti_pci_remove’:
>  drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
>  drivers/misc/pti.c: In function ‘pti_pci_probe’:
>  drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> 
> So make INTEL_MID_PTI depend on PCI to fix build error.

I think (hope) that Greg already has a patch like this queued.
Greg- are you planning to push some patches soon?


> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 0a4d86c..2d6423c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -146,6 +146,7 @@ config PHANTOM
>  
>  config INTEL_MID_PTI
>  	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> +	depends on PCI
>  	default n
>  	help
>  	  The PTI (Parallel Trace Interface) driver directs
> -- 

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-08-11 17:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 16:23 Tracey Dent
2011-08-11 16:45 ` Randy Dunlap [this message]
2011-08-11 16:56   ` Greg KH
2011-08-11 16:59   ` Tracey Dent
2011-08-18 16:24     ` Ingo Molnar
2011-08-18 18:39       ` Greg KH
2011-08-18 20:29         ` Ingo Molnar
2011-08-19 18:52         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811094520.4ee7819f.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tdent48227@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®