From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Axel Lin <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rakesh Iyer <riyer@nvidia.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH RESEND] Input: tegra-kbc - correct call to input_free_device
Date: Thu, 11 Aug 2011 09:51:34 -0700 [thread overview]
Message-ID: <20110811165134.GA24861@core.coreip.homeip.net> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24C0A@HQMAIL01.nvidia.com>
On Thu, Aug 11, 2011 at 09:42:54AM -0700, Stephen Warren wrote:
> Axel Lin wrote at Thursday, August 11, 2011 2:49 AM:
> > If kzalloc for kbc fails, then we have NULL pointer dereference while
> > calling input_free_device(kbc->idev) in the error handling.
> > So it is safer to always use the original name, input_dev.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
Gah, sorry, already pushed into my public branch so won't be able so
add your reviewed-by...
--
Dmitry
next prev parent reply other threads:[~2011-08-11 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 8:49 Axel Lin
2011-08-11 16:42 ` Stephen Warren
2011-08-11 16:51 ` Dmitry Torokhov [this message]
2011-08-11 17:14 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811165134.GA24861@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riyer@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®