From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292Ab1HLNNT (ORCPT ); Fri, 12 Aug 2011 09:13:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614Ab1HLNNQ (ORCPT ); Fri, 12 Aug 2011 09:13:16 -0400 Date: Fri, 12 Aug 2011 15:13:14 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki , Ying Han , Balbir Singh , KOSAKI Motohiro , Daisuke Nishimura , Mel Gorman Subject: Re: [patch 1/2] mm: vmscan: fix force-scanning small targets without swap Message-ID: <20110812131314.GC32335@tiehlicka.suse.cz> References: <1313094715-31187-1-git-send-email-jweiner@redhat.com> <20110812131042.GB32335@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110812131042.GB32335@tiehlicka.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 12-08-11 15:10:42, Michal Hocko wrote: > On Thu 11-08-11 22:31:54, Johannes Weiner wrote: > > Without swap, anonymous pages are not scanned. As such, they should > > not count when considering force-scanning a small target if there is > > no swap. > > > > Otherwise, targets are not force-scanned even when their effective > > scan number is zero and the other conditions--kswapd/memcg--apply. > > > > Signed-off-by: Johannes Weiner > > We are calculating nr_force_scan even if it is not needed but this > shouldn't hurt. Ahh and the second patch removes that calculation. Sorry for noise. > Reviewed-by: Michal Hocko -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic