From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312Ab1HLPH1 (ORCPT ); Fri, 12 Aug 2011 11:07:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51112 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093Ab1HLPH0 (ORCPT ); Fri, 12 Aug 2011 11:07:26 -0400 Date: Fri, 12 Aug 2011 11:07:16 -0400 From: Josh Boyer To: Oliver Neukum , Alexey ORISHKO Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4] usbnet/cdc_ncm: Don't use stack variables for DMA Message-ID: <20110812150715.GD3014@zod.bos.redhat.com> References: <20110808123406.GA2526@zod.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110808123406.GA2526@zod.bos.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2011 at 08:34:06AM -0400, Josh Boyer wrote: > The cdc_ncm driver still has a few places where stack variables are > passed to the cdc_ncm_do_request function. This triggers a stack trace in > lib/dma-debug.c if the CONFIG_DEBUG_DMA_API option is set. > > Adjust these calls to pass parameters that have been allocated with > kzalloc. > > Signed-off-by: Josh Boyer > --- > v4: Rebase against 3.1-rc1 > v3: Fix checkpatch errors > v2: Fix leak in error path > > drivers/net/usb/cdc_ncm.c | 47 ++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 38 insertions(+), 9 deletions(-) Just curious, but which tree would this be pulled into? usb or net or? josh