From: Dmitry Artamonow <mad_soft@inbox.ru>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
Ian Dobson <i.dobson@planet-ian.com>,
Jean Delvare <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: add caseopen detection to w83627ehf driver
Date: Sat, 13 Aug 2011 00:38:25 +0400 [thread overview]
Message-ID: <20110812203824.GB32369@rainbow> (raw)
In-Reply-To: <1313084814.2214.100.camel@groeck-laptop>
On 10:46 Thu 11 Aug , Guenter Roeck wrote:
> Hi Dmitry,
>
> please consider the changes suggested below.
[...]
> > +static struct sensor_device_attribute sda_caseopen[] = {
> > + SENSOR_ATTR(intrusion0_alarm, S_IWUSR | S_IRUGO, show_caseopen,
> > + clear_caseopen, 0),
> > + SENSOR_ATTR(intrusion1_alarm, S_IWUSR | S_IRUGO, show_caseopen,
> > + clear_caseopen, 1),
>
> SENSOR_ATTR_2(intrusion0_alarm, S_IWUSR | S_IRUGO,
> show_caseopen, clear_caseopen, 0x80, 0x10),
> SENSOR_ATTR_2(intrusion1_alarm, S_IWUSR | S_IRUGO,
> show_caseopen, clear_caseopen, 0x40, 0x40),
>
Oh, yeah! That's much neater with SENSOR_ATTR_2 - thanks for suggestion!
I've seen it while looking to other hwmon drivers, but missed the difference
from plain SENSOR_ATTR...
I've incorporated your suggested changes into v3 of the patch - it will follow
this mail.
--
Best regards,
Dmitry "MAD" Artamonow
prev parent reply other threads:[~2011-08-12 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 20:56 Dmitry Artamonow
2011-08-11 17:46 ` Guenter Roeck
2011-08-12 20:38 ` Dmitry Artamonow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812203824.GB32369@rainbow \
--to=mad_soft@inbox.ru \
--cc=guenter.roeck@ericsson.com \
--cc=i.dobson@planet-ian.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®