From: Sam Ravnborg <sam@ravnborg.org>
To: Pavel Roskin <proski@gnu.org>, Michal Marek <mmarek@suse.cz>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparse: always enable endian checks
Date: Mon, 15 Aug 2011 20:33:59 +0200 [thread overview]
Message-ID: <20110815183358.GA31530@merkur.ravnborg.org> (raw)
In-Reply-To: <20110815160440.6296.95762.stgit@mj>
On Mon, Aug 15, 2011 at 12:04:41PM -0400, Pavel Roskin wrote:
> Checks enabled by __CHECK_ENDIAN__ produce less than a half of the
> sparse warnings. For instance, the allyesconfig configuration on
> linux-next (tag next-20110812) produces on x86_64:
>
> no __CHECK_ENDIAN__ with __CHECK_ENDIAN__
> stderr bytes: 1155037 1992954 (73% increase)
> stderr lines: 10716 18657 (74% increase)
> affected files: 1191 1458 (22% increase)
>
> It is no longer true that __CHECK_ENDIAN__ produces so many warnings
> that other sparse warnings drown in the noise.
>
> Janitors going through the whole tree are already prepared to search for
> the warnings they want to fix.
>
> The main point of this patch is to make sure that developers of a
> particular driver who use sparse rarely get all the warnings for their
> code even if they forget to specify __CHECK_ENDIAN__ or mistype it.
>
> Some developers actually added __CHECK_ENDIAN__ to the driver makefiles
> so they don't forget to use it. Remove them now.
>
> Remove all references to __CHECK_ENDIAN__ from the documentation except
> the Chinese version, which would need to be updated separately.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Maybe ask Michal to merge it?
Sam
next prev parent reply other threads:[~2011-08-15 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 16:04 Pavel Roskin
2011-08-15 18:33 ` Sam Ravnborg [this message]
2011-08-18 10:10 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815183358.GA31530@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®