From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751724Ab1HORbV (ORCPT ); Mon, 15 Aug 2011 13:31:21 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:44943 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790Ab1HORbU (ORCPT ); Mon, 15 Aug 2011 13:31:20 -0400 From: Laurent Pinchart To: Peter Huewe Subject: Re: [PATCH] video/atmel_lcdfb: Fix build failure/typo for avr32 defconfig Date: Mon, 15 Aug 2011 19:31:27 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.37-gentoo-r3; KDE/4.6.5; x86_64; ; ) Cc: Nicolas Ferre , Paul Mundt , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell References: <1313429190-29275-1-git-send-email-peterhuewe@gmx.de> In-Reply-To: <1313429190-29275-1-git-send-email-peterhuewe@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108151931.27607.laurent.pinchart@ideasonboard.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Monday 15 August 2011 19:26:30 Peter Huewe wrote: > This patch fixes a typo which causes this build failure for the > avr32 defconfig: > > drivers/video/atmel_lcdfb.c:63: error: request for member 'xres_virtual' > in something not a structure or union > make[3]: *** [drivers/video/atmel_lcdfb.o] Error 1 > > The typo was introduced by 895607ec > "atmel_lcdfb: use display information in info not in var for panning" > > KernelVersion: Linux-next 20110812 > The typo was introduced through the fbdev tree. Thanks for the patch. I've already submitted the same patch (https://patchwork.kernel.org/patch/990792/) nearly a month ago to the linux- fbdev mailing list. Paul, can you please pick it up ? > Signed-off-by: Peter Huewe > --- > So much for compile testing... ;) > > drivers/video/atmel_lcdfb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 77153c6..63409c1 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -60,7 +60,7 @@ static void atmel_lcdfb_update_dma2d(struct > atmel_lcdfb_info *sinfo, > > pixeloff = (var->xoffset * info->var.bits_per_pixel) & 0x1f; > > - dma2dcfg = (info-var.xres_virtual - info->var.xres) > + dma2dcfg = (info->var.xres_virtual - info->var.xres) > * info->var.bits_per_pixel / 8; > dma2dcfg |= pixeloff << ATMEL_LCDC_PIXELOFF_OFFSET; > lcdc_writel(sinfo, ATMEL_LCDC_DMA2DCFG, dma2dcfg); -- Regards, Laurent Pinchart