From: Shawn Guo <shawn.guo@freescale.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Colin Cross <ccross@android.com>,
Erik Gilling <konkers@android.com>,
Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-tegra@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Belisko Marek <marek.belisko@gmail.com>,
Jamie Iles <jamie@jamieiles.com>,
Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [RFC PATCH v2 09/13] gpio/tegra: Add device tree support
Date: Tue, 16 Aug 2011 11:39:01 +0800 [thread overview]
Message-ID: <20110816033900.GF8044@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <1313440100-17131-10-git-send-email-swarren@nvidia.com>
On Mon, Aug 15, 2011 at 02:28:16PM -0600, Stephen Warren wrote:
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/gpio/gpio-tegra.c | 32 ++++++++++++++++++++++++++++++++
> 1 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 4da4839..1d0a764 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -326,6 +326,30 @@ static struct irq_chip tegra_gpio_irq_chip = {
> #endif
> };
>
> +#ifdef CONFIG_OF
> +static void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> +{
> + const __be32 *gpios;
> + u32 gpioslen;
> + int i;
> +
> + gpios = of_get_property(pdev->dev.of_node, "nvidia,enabled-gpios",
> + &gpioslen);
> + if (gpios == NULL)
> + return;
> +
> + gpioslen /= sizeof(*gpios);
> + for (i = 0; i < gpioslen; i++, gpios++) {
> + u32 gpio = be32_to_cpup(gpios);
> + dev_dbg(&pdev->dev, "Enabling GPIO %d\n", gpio);
> + tegra_gpio_enable(gpio);
> + }
> +}
> +#else
> +static inline void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> +{
> +}
> +#endif
>
With your patch below being merged, and the suggestion that
of_property_read_u32[_array] should be used to read integer from
device tree, the #ifdef thing can be removed?
[PATCH] dt: add empty of_get_property for non-dt
Regards,
Shawn
> /* This lock class tells lockdep that GPIO irqs are in a different
> * category than their parents, so it won't report false recursion.
> @@ -371,13 +395,21 @@ static int __init tegra_gpio_probe(struct platform_device *pdev)
> spin_lock_init(&bank->lvl_lock[j]);
> }
>
> + tegra_gpio_probe_dt(pdev);
> +
> return 0;
> }
>
> +static struct of_device_id tegra_gpio_of_match[] __devinitdata = {
> + { .compatible = "nvidia,tegra20-gpio", },
> + { },
> +};
> +
> static struct platform_driver tegra_gpio_driver = {
> .driver = {
> .name = "tegra-gpio",
> .owner = THIS_MODULE,
> + .of_match_table = tegra_gpio_of_match,
> },
> .probe = tegra_gpio_probe,
> };
> --
> 1.7.0.4
>
>
next prev parent reply other threads:[~2011-08-16 3:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 20:28 [RFC PATCH v2 00/13] arm/tegra: Initialize GPIO & pinmux from DT Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 01/13] arm/tegra: Prep boards for gpio/pinmux conversion to pdevs Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 02/13] arm/tegra: Avoid duplicate gpio/pinmux devices with dt Stephen Warren
2011-08-16 20:46 ` Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 03/13] arm/tegra: board-dt: Add AUXDATA for tegra-gpio and tegra-pinmux Stephen Warren
2011-08-16 3:30 ` Shawn Guo
2011-08-16 20:24 ` Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 04/13] docs/dt: Document nvidia,tegra20-gpio's nvidia,enabled-gpios property Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 05/13] arm/dt: Tegra: Add nvidia,gpios property to GPIO controller Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 06/13] docs/dt: Document nvidia,tegra20-pinmux binding Stephen Warren
2011-08-16 3:48 ` Shawn Guo
2011-08-16 13:51 ` Arnd Bergmann
2011-08-16 17:32 ` Stephen Warren
2011-08-17 6:02 ` Shawn Guo
2011-08-17 6:17 ` Shawn Guo
2011-08-17 11:37 ` Arnd Bergmann
2011-08-17 11:43 ` Jamie Iles
2011-08-18 6:36 ` Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 07/13] arm/dt: Tegra: Add pinmux node Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 08/13] gpio/tegra: Convert to a platform device Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 09/13] gpio/tegra: Add device tree support Stephen Warren
2011-08-16 3:39 ` Shawn Guo [this message]
2011-08-15 20:28 ` [RFC PATCH v2 10/13] arm/tegra: Convert pinmux driver to a platform device Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 11/13] arm/tegra: Add device tree support to pinmux driver Stephen Warren
2011-08-16 3:45 ` Shawn Guo
2011-08-23 23:35 ` Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 12/13] arm/tegra: board-dt: Remove dependency on non-dt pinmux functions Stephen Warren
2011-08-15 20:28 ` [RFC PATCH v2 13/13] arm/tegra: Remove temporary gpio/pinmux registration workaround Stephen Warren
2011-08-16 13:09 ` [RFC PATCH v2 00/13] arm/tegra: Initialize GPIO & pinmux from DT Arnd Bergmann
2011-08-16 14:01 ` Linus Walleij
2011-08-16 14:37 ` Arnd Bergmann
2011-08-16 14:45 ` Linus Walleij
2011-08-16 17:12 ` Stephen Warren
2011-08-17 11:23 ` Arnd Bergmann
2011-08-18 6:22 ` Stephen Warren
2011-08-18 9:15 ` Arnd Bergmann
2011-08-23 12:51 ` Linus Walleij
2011-08-23 18:49 ` Stephen Warren
2011-08-23 20:00 ` Linus Walleij
2011-08-22 19:56 ` Stephen Warren
2011-08-22 22:56 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816033900.GF8044@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek.belisko@gmail.com \
--cc=olof@lixom.net \
--cc=sshtylyov@mvista.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®