From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511Ab1HPL4N (ORCPT ); Tue, 16 Aug 2011 07:56:13 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:10246 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890Ab1HPL4L (ORCPT ); Tue, 16 Aug 2011 07:56:11 -0400 Date: Tue, 16 Aug 2011 13:55:52 +0200 From: Jean Delvare To: Julia Lawall Cc: Mauro Carvalho Chehab , kernel-janitors@vger.kernel.org, Paul Gortmaker , Lucas De Marchi , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless initialization Message-ID: <20110816135552.655ef654@endymion.delvare> In-Reply-To: <1312453774-23333-4-git-send-email-julia@diku.dk> References: <1312453774-23333-1-git-send-email-julia@diku.dk> <1312453774-23333-4-git-send-email-julia@diku.dk> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, On Thu, 4 Aug 2011 12:29:33 +0200, Julia Lawall wrote: > From: Julia Lawall > > Delete nontrivial initialization that is immediately overwritten by the > result of an allocation function. > (...) > Signed-off-by: Julia Lawall > > --- > drivers/media/video/hexium_gemini.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/media/video/hexium_gemini.c b/drivers/media/video/hexium_gemini.c > --- a/drivers/media/video/hexium_gemini.c > +++ b/drivers/media/video/hexium_gemini.c > @@ -352,7 +352,7 @@ static struct saa7146_ext_vv vv_data; > /* this function only gets called when the probing was successful */ > static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_data *info) > { > - struct hexium *hexium = (struct hexium *) dev->ext_priv; > + struct hexium *hexium; > int ret; > > DEB_EE((".\n")); > Looks correct. Acked-by: Jean Delvare -- Jean Delvare