From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750896Ab1HQELP (ORCPT ); Wed, 17 Aug 2011 00:11:15 -0400 Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:37426 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750756Ab1HQELM (ORCPT ); Wed, 17 Aug 2011 00:11:12 -0400 Date: Tue, 16 Aug 2011 21:11:09 -0700 From: Jesse Barnes To: Benjamin Herrenschmidt Cc: David Daney , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Grant Likely Subject: Re: [PATCH] pci/of: Don't crash when bridge parent is NULL. Message-ID: <20110816211109.13c80d34@jbarnes-e6510> In-Reply-To: <1313522178.3664.69.camel@pasglop> References: <1313519077-18457-1-git-send-email-david.daney@cavium.com> <1313522178.3664.69.camel@pasglop> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.161.37.189 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Aug 2011 14:16:18 -0500 Benjamin Herrenschmidt wrote: > On Tue, 2011-08-16 at 11:24 -0700, David Daney wrote: > > In pcibios_get_phb_of_node(), we will crash while booting if > > bus->bridge->parent is NULL. > > > > Check for this case and avoid dereferencing the NULL pointer. > > > > Signed-off-by: David Daney > > Acked-by: Benjamin Herrenschmidt > > Jesse or Grant, I'm travelling, can any of you send that to Linus > asap ? Sure looks fine. I'll send it off tomorrow (now that I'm back :). Thanks, Jesse