From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124Ab1HPVqK (ORCPT ); Tue, 16 Aug 2011 17:46:10 -0400 Received: from mail-iy0-f170.google.com ([209.85.210.170]:58817 "EHLO mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954Ab1HPVqI (ORCPT ); Tue, 16 Aug 2011 17:46:08 -0400 Date: Wed, 17 Aug 2011 00:43:52 +0300 From: Dan Carpenter To: Pekka Enberg Cc: =?iso-8859-1?Q?G=E1bor?= Stefanik , devel@driverdev.osuosl.org, Greg Kroah-Hartman , Akshay Joshi , linux-kernel@vger.kernel.org, Karthigan Srinivasan , Pavel Machek Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond. Message-ID: <20110816214352.GK26027@shale.localdomain> References: <1313454275-5604-1-git-send-email-me@akshayjoshi.com> <1313454275-5604-4-git-send-email-me@akshayjoshi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2011 at 12:24:06AM +0300, Pekka Enberg wrote: > 2011/8/16 Gábor Stefanik : > >> - > >> -//==================================== > >> -// Internal variable for module > >> -//==================================== > >> +/*============================================================================ > >> +/* wb35rx.h -- > >> +/*============================================================================ > > > > I'm pretty sure this is not an accepted kernel comment style. > > What's the problem? I think it's OK for this particular patch. There are a five start open comment "/*" marks in a row that don't have a matching close comment. regards, dan carpenter