From: Sam Ravnborg <sam@ravnborg.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: "lkml, " <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Gary Thomas <gary@mlbassoc.com>,
"Woodhouse, David" <david.woodhouse@intel.com>
Subject: Re: can't build modules after clean for powerpc
Date: Wed, 17 Aug 2011 09:49:31 +0200 [thread overview]
Message-ID: <20110817074931.GA2629@merkur.ravnborg.org> (raw)
In-Reply-To: <4E4B0D28.7010905@linux.intel.com>
On Tue, Aug 16, 2011 at 05:36:56PM -0700, Darren Hart wrote:
> According to the Makefile comments and
> Documentation/kconfig/makefile.txt, make clean should leave enough
> intact to build modules with:
>
> ###
> # Cleaning is done on three levels.
> # make clean Delete most generated files
> # Leave enough to build external modules
>
> The following line in the arch/powerpc/Makefile prevents that from working:
>
> KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
>
> External module compilation fails to link as it can't find
> arch/powerpc/lib/crtsavres.o.
>
> It appears from the make logs that crtsavres.o is linked in to
> built-in.o, and thus vmlinux. If that is the case, it doesn't seem like
> crtsavres.o should need to be singled out. What am I missing here?
>
> If I comment it out:
>
> #KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
>
> my example module builds successfully.
>
> If it is necessary, then we need a means to instruct the top level
> makefile to not delete it during "clean". Is there such a directive?
>
> KBUILD_CLEAN_EXCLUDE_MODULES or something?
Hi Darren.
Try this small patch. Untested and cut'n'pasted...
Sam
diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
index 166a6a0..7a577f8 100644
--- a/arch/powerpc/lib/Makefile
+++ b/arch/powerpc/lib/Makefile
@@ -30,3 +30,6 @@ obj-$(CONFIG_PPC_LIB_RHEAP) += rheap.o
obj-y += code-patching.o
obj-y += feature-fixups.o
obj-$(CONFIG_FTR_FIXUP_SELFTEST) += feature-fixups-test.o
+
+# crtsavres is used by modules - so we need it after "make clean"
+no-clean-files := crtsavres.o
>
> Thanks,
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2011-08-17 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 0:36 Darren Hart
2011-08-17 7:49 ` Sam Ravnborg [this message]
2011-08-17 19:02 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817074931.GA2629@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=david.woodhouse@intel.com \
--cc=dvhart@linux.intel.com \
--cc=gary@mlbassoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®