From: Tejun Heo <tj@kernel.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, stable@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] i386/bigsmp: eliminate false warnings regarding logical APIC ID mismatches
Date: Thu, 18 Aug 2011 17:15:57 +0200 [thread overview]
Message-ID: <20110818151557.GE20085@htj.dyndns.org> (raw)
In-Reply-To: <4E4D47A30200007800051DAC@nat28.tlf.novell.com>
On Thu, Aug 18, 2011 at 04:10:59PM +0100, Jan Beulich wrote:
> > Hmmm... the only thing it can break is numa affinity of static percpu
> > areas (it doesn't even affect that anymore), which didn't work at all
> > on i386 before and keeps to not working for those exotic apic machines
> > anyway. Silencing the warnings wouldn't hurt anything at all. If
> > you're still concerned that something legitimate might trigger it,
> > wouldn't converting WARN_ON() there to printk_once() be enough? That
> > doesn't change the behavior at all sans lesser noise.
>
> That might be reasonable to do, yet I still think that changing what got
> produced with by the older APIC driver to what the new one would have
> produced when the driver gets changed is more consistent than just
> printing something, until the method in question is gone altogether.
Sure, either seems fine to me. Please feel free to add my acked-by.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-08-18 15:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 12:54 Jan Beulich
2011-08-18 13:04 ` Tejun Heo
2011-08-18 13:58 ` Jan Beulich
2011-08-18 14:02 ` Tejun Heo
2011-08-18 15:10 ` Jan Beulich
2011-08-18 15:15 ` Tejun Heo [this message]
2011-08-29 10:18 ` Stratos Psomadakis
2011-09-05 8:05 ` Jan Beulich
2011-09-26 16:13 ` Konrad Rzeszutek Wilk
2011-09-27 8:57 ` Jan Beulich
2011-09-27 13:35 ` Ingo Molnar
2011-09-27 14:39 ` Jan Beulich
2011-09-27 14:42 ` Ingo Molnar
2011-09-15 8:30 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818151557.GE20085@htj.dyndns.org \
--to=tj@kernel.org \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®