From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818Ab1HRU4H (ORCPT ); Thu, 18 Aug 2011 16:56:07 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:50946 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509Ab1HRU4F (ORCPT ); Thu, 18 Aug 2011 16:56:05 -0400 From: "Rafael J. Wysocki" To: Stephen Rothwell Subject: Re: linux-next: build warning after merge of the moduleh tree Date: Thu, 18 Aug 2011 22:57:44 +0200 User-Agent: KMail/1.13.6 (Linux/3.1.0-rc2+; KDE/4.6.0; x86_64; ; ) Cc: Paul Gortmaker , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20110818150945.b429ef302fd45a6a309b52d4@canb.auug.org.au> <201108181026.51813.rjw@sisk.pl> <20110818192754.972382bbed8fa3adc6dca9c5@canb.auug.org.au> In-Reply-To: <20110818192754.972382bbed8fa3adc6dca9c5@canb.auug.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Message-Id: <201108182257.44926.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 18, 2011, Stephen Rothwell wrote: > Hi Rafael, > > On Thu, 18 Aug 2011 10:26:51 +0200 "Rafael J. Wysocki" wrote: > > > > Do you mean that drivers/base/power/common.c should include module.h > > or something else? > > Yes, that is exactly what I mean :-) See Rule 1 in > Documentation/SubmitChecklist. The reason it is different, is because > the module.h splitup is cerating export.h for files that just need > EXPORT_SYMBOL (like this file). OK, I've modified common.c so that module.h is included. Thanks, Rafael