From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348Ab1HSSwp (ORCPT ); Fri, 19 Aug 2011 14:52:45 -0400 Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:41237 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754201Ab1HSSwo (ORCPT ); Fri, 19 Aug 2011 14:52:44 -0400 Date: Fri, 19 Aug 2011 11:52:41 -0700 From: Randy Dunlap To: Greg KH Cc: Ingo Molnar , Tracey Dent , linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected Message-Id: <20110819115241.5e53f411.rdunlap@xenotime.net> In-Reply-To: <20110818183939.GD18881@suse.de> References: <20110811162306.GA30710@tj-desktop> <20110811094520.4ee7819f.rdunlap@xenotime.net> <20110811165911.GA6454@tj-desktop> <20110818162419.GA26627@kernel.org> <20110818183939.GD18881@suse.de> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Aug 2011 11:39:39 -0700 Greg KH wrote: > On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote: > > > > * Tracey Dent wrote: > > > > > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote: > > > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote: > > > > > > > > > When you try to build INTEL_MID_PTI without having PCI > > > > > enabled. It fails like this- > > > > > > > > > > CC [M] drivers/misc/pti.o > > > > > drivers/misc/pti.c: In function ‘pti_pci_remove’: > > > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ > > > > > drivers/misc/pti.c: In function ‘pti_pci_probe’: > > > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’ > > > > > > > > > > So make INTEL_MID_PTI depend on PCI to fix build error. > > > > > > > > I think (hope) that Greg already has a patch like this queued. > > > > Greg- are you planning to push some patches soon? > > > > > > > > > > > > > > Okay, sorry for the noise then. > > > > FYI, The fix is still not upstream, as of today's -git > > (72ed62bdc46d): > > > > drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] > > drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration] > > Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week. > He's busy as well, so it's not like he could pull while underwater > anyway :) I guess he did merge patches somehow yesterday.... --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***