From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756325Ab1HSWWN (ORCPT ); Fri, 19 Aug 2011 18:22:13 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:64088 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754575Ab1HSWWL (ORCPT ); Fri, 19 Aug 2011 18:22:11 -0400 Date: Fri, 19 Aug 2011 15:22:03 -0700 From: Dmitry Torokhov To: Daniel Kurtz Cc: chase.douglas@canonical.com, rydberg@euromail.se, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, olofj@chromium.org, chris@cnpbagwell.com Subject: Re: [PATCH 4/9 v4] Input: synaptics - add image sensor support Message-ID: <20110819222203.GC5146@core.coreip.homeip.net> References: <1313666888-18939-1-git-send-email-djkurtz@chromium.org> <1313666888-18939-5-git-send-email-djkurtz@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1313666888-18939-5-git-send-email-djkurtz@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Thu, Aug 18, 2011 at 07:28:03PM +0800, Daniel Kurtz wrote: > @@ -558,6 +626,11 @@ static void synaptics_process_packet(struct psmouse *psmouse) > if (synaptics_parse_hw_state(psmouse->packet, priv, &hw)) > return; > > + if (SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)) { > + synaptics_image_sensor_process(psmouse, &hw); > + return; > + } > + So what about the rest of the SYnaptics processing (wheel, additional buttons, etc)? Are we sure that touchpads with image sensors will never implement them? -- Dmitry