From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688Ab1HWAuD (ORCPT ); Mon, 22 Aug 2011 20:50:03 -0400 Received: from oproxy9.bluehost.com ([69.89.24.6]:47059 "HELO oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754577Ab1HWAuB convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2011 20:50:01 -0400 Date: Mon, 22 Aug 2011 17:49:58 -0700 From: Randy Dunlap To: Arnaud Lacombe Cc: Stephen Rothwell , Mimi Zohar , linux-next@vger.kernel.org, LKML , linux-kbuild@vger.kernel.org Subject: Re: linux-next: Tree for Aug 22 (evm) Message-Id: <20110822174958.73dd96c7.rdunlap@xenotime.net> In-Reply-To: References: <20110822145304.980529cb921e5f1321c622da@canb.auug.org.au> <20110822125355.bb01d76b.rdunlap@xenotime.net> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote: > Hi, > > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap wrote: > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote: > > > >> Hi all, > >> > >> [The kernel.org mirroring is a bit low today] > > > > (on x86_64:) > > > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m, > > CONFIG_ENCRYPTED_KEYS=m, the build fails with: > > > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was > 'm'. That said, correct me if I'm wrong, but we currently have: Yes, it was 'm'. > menuconfig TCG_TPM > tristate "TPM Hardware Support" > > [...] > > config EVM > boolean "EVM support" > depends on SECURITY && KEYS && TCG_TPM > > which seems terribly broken to me... How can you have a built-in > feature, which depends on another potentially-not-built-in feature ? Yup. > If you change EVM to 'tristate', you will see that you are not allowed > to make it built-in if TCG_TPM is not built-in. Right. > - Arnaud > > > (.text+0x378aa): undefined reference to `key_type_encrypted' > > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash' > > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey' > > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update' > > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final' > > (.text+0x37b4b): undefined reference to `crypto_shash_update' > > (.text+0x37c61): undefined reference to `crypto_shash_update' > > (.text+0x37cb9): undefined reference to `crypto_shash_update' > > > > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS.. > > and even after I add "select CRYPTO_HASH2". > > > > Is this because EVM is bool and kconfig is confused about 'select's > > when a bool is selecting tristates?  Shouldn't the tristates become > > 'y' instead of 'm' if they are selected by a bool that is 'y'? > > > > > > xconfig shows these symbol values: > > > > Symbol: EVM [=y] > > Type : boolean > > Prompt: EVM support > > Defined at security/integrity/evm/Kconfig:1 > > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m] > > Location: > > -> Security options > > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m] > > > > > > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and > > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max > > symbol checking that is confused? > > > there is definitively an underlying min/max, but I would not point > finger too fast. Thanks for your help. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***