From: Greg KH <greg@kroah.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] libfs: fix simple_attr_write on 32bit machine
Date: Mon, 22 Aug 2011 17:38:14 -0700 [thread overview]
Message-ID: <20110823003814.GB5982@kroah.com> (raw)
In-Reply-To: <1310187626-2371-1-git-send-email-akinobu.mita@gmail.com>
On Sat, Jul 09, 2011 at 02:00:26PM +0900, Akinobu Mita wrote:
> Assume that /sys/kernel/debug/dummy64 is debugfs file created by
> debugfs_create_x64().
>
> # cd /sys/kernel/debug
> # echo 0x1234567812345678 > dummy64
> # cat dummy64
> 0x0000000012345678
>
> # echo 0x80000000 > dummy64
> # cat dummy64
> 0xffffffff80000000
>
> The value more than INT_MAX cannot be written to the debugfs file
> created by debugfs_create_u64 or debugfs_create_x64 on 32bit machine.
> Because simple_attr_write() uses simple_strtol() for the conversion.
>
> To fix this, use simple_strtoll() instead.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Do we have any debugfs files that need this change in the tree now for
3.1 or newer?
thanks,
greg k-h
next prev parent reply other threads:[~2011-08-23 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 5:00 Akinobu Mita
2011-07-12 22:24 ` Andrew Morton
2011-08-23 0:38 ` Greg KH [this message]
2011-08-23 15:05 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823003814.GB5982@kroah.com \
--to=greg@kroah.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®